sorry, you are absolutely right. The ESLint plugin would not include
eslint-plugin-jsx-a11y. SonarJS does, that’s why I mixed both things. So removing our dependency onjsx-ast-utilswould indeed affect the package size. I’ll update the ticket.
Alright, thank you!
About TypeScript, it is an actual dependency as we import and use TypeScript API directly in some of the rules, so it does not fit the definition of a peer dependency.
Wait wait wait. You can’t import peers? I need to go see how much of my code is broken lol.
No, it looks like you can import a peerDependency, and you want to make sure you use the version the user is so that they stay in sync, it’s kinda like ESLint is a “ts plugin” (except that that’s an actual thing).
Of course, the rules using typescript will not be executed if the ESlint plugin user does not use TypeScript or does not specify a
tsconfig.json. We are very aware that TS is the biggest offender in terms of package size, and we would be happy to find a better solution than the current one (probably optionalDependency?).
Unfortunately, optionalDependencies are installed by default so most projects use optional peerDependencies instead (like I was suggesting)
About the actual version, we used >=5 because it is wide enough for the big majority of users to avoid another version being installed aside of the user’s TS.
Oh, I was saying that it’s not >=5 when it probably should be, especially with ts6 coming soon. It’s currently ^5.
Thanks for bearing with me!