Hi there,
we using TS+rxjs 6 (temporary with old way syntax of effects and actions) for angular project (tested angular 12-13).
We actualy just setting up technical demo and every possible solutions for our projects (we started with angular and node projects).
SonarQube are on local docker env with developer testing license and remote postgress SQL DB.
Issue:
When we generate esLint report by json format, and we define correct path in config of sonar we always get errors on files where are defined rxjs selectors.
- versions used (SonarQube, Scanner, Plugin, and any relevant extension)
SonarQube 9.3 server, runned by local cli - error observed (wrap logs/code around triple quote ``` for proper formatting)
INFO: Final Memory: 24M/114M
INFO: ------------------------------------------------------------------------
ERROR: Error during SonarScanner execution
java.lang.IllegalArgumentException: 650 is not a valid line offset for pointer. File src/app/fixed-panel/reducers/index.ts has 77 character(s) at line 21
at org.sonar.api.utils.Preconditions.checkArgument(Preconditions.java:43)
at org.sonar.api.batch.fs.internal.DefaultInputFile.checkValid(DefaultInputFile.java:339)
at org.sonar.api.batch.fs.internal.DefaultInputFile.newPointer(DefaultInputFile.java:272)
at org.sonar.api.batch.fs.internal.DefaultInputFile.newRange(DefaultInputFile.java:288)
at org.sonar.plugins.javascript.external.EslintReportSensor.getLocation(EslintReportSensor.java:117)
at org.sonar.plugins.javascript.external.EslintReportSensor.saveEslintError(EslintReportSensor.java:85)
at org.sonar.plugins.javascript.external.EslintReportSensor.importReport(EslintReportSensor.java:68)
at org.sonar.plugins.javascript.external.AbstractExternalIssuesSensor.lambda$execute$1(AbstractExternalIssuesSensor.java:54)
at java.base/java.util.ArrayList.forEach(Unknown Source)
at org.sonar.plugins.javascript.external.AbstractExternalIssuesSensor.execute(AbstractExternalIssuesSensor.java:54)
at org.sonar.plugins.javascript.external.EslintReportSensor.execute(EslintReportSensor.java:43)
at org.sonar.scanner.sensor.AbstractSensorWrapper.analyse(AbstractSensorWrapper.java:64)
at org.sonar.scanner.sensor.ModuleSensorsExecutor.execute(ModuleSensorsExecutor.java:85)
at org.sonar.scanner.sensor.ModuleSensorsExecutor.lambda$execute$1(ModuleSensorsExecutor.java:59)
at org.sonar.scanner.sensor.ModuleSensorsExecutor.withModuleStrategy(ModuleSensorsExecutor.java:77)
at org.sonar.scanner.sensor.ModuleSensorsExecutor.execute(ModuleSensorsExecutor.java:59)
at org.sonar.scanner.scan.ModuleScanContainer.doAfterStart(ModuleScanContainer.java:79)
at org.sonar.core.platform.ComponentContainer.startComponents(ComponentContainer.java:137)
at org.sonar.core.platform.ComponentContainer.execute(ComponentContainer.java:123)
at org.sonar.scanner.scan.ProjectScanContainer.scan(ProjectScanContainer.java:384)
at org.sonar.scanner.scan.ProjectScanContainer.scanRecursively(ProjectScanContainer.java:380)
at org.sonar.scanner.scan.ProjectScanContainer.doAfterStart(ProjectScanContainer.java:349)
at org.sonar.core.platform.ComponentContainer.startComponents(ComponentContainer.java:137)
at org.sonar.core.platform.ComponentContainer.execute(ComponentContainer.java:123)
at org.sonar.scanner.bootstrap.GlobalContainer.doAfterStart(GlobalContainer.java:136)
at org.sonar.core.platform.ComponentContainer.startComponents(ComponentContainer.java:137)
at org.sonar.core.platform.ComponentContainer.execute(ComponentContainer.java:123)
at org.sonar.batch.bootstrapper.Batch.doExecute(Batch.java:72)
at org.sonar.batch.bootstrapper.Batch.execute(Batch.java:66)
at org.sonarsource.scanner.api.internal.batch.BatchIsolatedLauncher.execute(BatchIsolatedLauncher.java:46)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at org.sonarsource.scanner.api.internal.IsolatedLauncherProxy.invoke(IsolatedLauncherProxy.java:60)
at com.sun.proxy.$Proxy0.execute(Unknown Source)
at org.sonarsource.scanner.api.EmbeddedScanner.doExecute(EmbeddedScanner.java:189)
at org.sonarsource.scanner.api.EmbeddedScanner.execute(EmbeddedScanner.java:138)
at org.sonarsource.scanner.cli.Main.execute(Main.java:112)
at org.sonarsource.scanner.cli.Main.execute(Main.java:75)
at org.sonarsource.scanner.cli.Main.main(Main.java:61)
ERROR:
ERROR: Re-run SonarScanner using the -X switch to enable full debug logging.
False detected as broken file: src/app/fixed-panel/reducers/index.ts
import { createFeatureSelector, createSelector } from '@ngrx/store';
import {
AppointmentListState,
getErrorMessageState,
getAppointmentsLoadingState,
getVisibleAppointmentsState,
geTodayShownState,
getNoDefaultPastEventsState,
getNoDefaultUpcomingEventsState,
getAppointmentsIdsState,
getFirstVisibleIdState,
getNowOffsetState,
getVisibleItemsCountState,
getPreviousPaginationDisabledState,
getNextPaginationDisabledState,
getPatientIdState,
} from 'app/fixed-panel/reducers/appointments.reducer';
export const appointmentsFeatureName = Symbol('appointments');
export const appointmentsState = createFeatureSelector<AppointmentListState>(
appointmentsFeatureName.toString(),
);
export const getAppointmentsLoading = createSelector(
appointmentsState,
getAppointmentsLoadingState,
);
export const getVisibleAppointments = createSelector(
appointmentsState,
getVisibleAppointmentsState,
);
export const getErrorMessage = createSelector(appointmentsState, getErrorMessageState);
export const getAppointmentsIds = createSelector(appointmentsState, getAppointmentsIdsState);
export const getFirstVisibleId = createSelector(appointmentsState, getFirstVisibleIdState);
export const getNowOffset = createSelector(appointmentsState, getNowOffsetState);
export const getVisibleItemsCount = createSelector(appointmentsState, getVisibleItemsCountState);
export const getTodayShown = createSelector(appointmentsState, geTodayShownState);
export const getNoDefaultPastEvents = createSelector(
appointmentsState,
getNoDefaultPastEventsState,
);
export const getNoDefaultUpcomingEvents = createSelector(
appointmentsState,
getNoDefaultUpcomingEventsState,
);
export const getPreviousPaginationDisabled = createSelector(
appointmentsState,
getPreviousPaginationDisabledState,
);
export const getNextPaginationDisabled = createSelector(
appointmentsState,
getNextPaginationDisabledState,
);
export const getPatientId = createSelector(appointmentsState, getPatientIdState);
package.json
"dependencies": {
"@agm/core": "~3.0.0-beta.0",
"@angular/animations": "~13.2.5",
"@angular/cdk": "~13.2.5",
"@angular/common": "~13.2.5",
"@angular/compiler": "~13.2.5",
"@angular/core": "~13.2.5",
"@angular/elements": "~13.2.5",
"@angular/forms": "~13.2.5",
"@angular/localize": "~13.2.5",
"@angular/platform-browser": "~13.2.5",
"@angular/platform-browser-dynamic": "~13.2.5",
"@angular/router": "~13.2.5",
"@ckeditor/ckeditor5-angular": "~2.0.2",
"@ckeditor/ckeditor5": "bart-sk/ckeditor5",
"@formio/angular": "~5.2.2",
"@ngrx/effects": "~13.0.2",
"@ngrx/store": "~13.0.2",
"@sentry/angular": "~6.18.1",
"@sentry/tracing": "~6.18.1",
"@syncfusion/ej2-angular-documenteditor": "~19.4.55",
"angular-email-editor": "~0.9.0",
"core-js": "~3.21.1",
"create-hmac": "~1.1.7",
"croppie": "~2.6.5",
"dom-autoscroller": "~2.3.4",
"dwt": "~17.2.3",
"file-saver": "~2.0.5",
"formiojs": "~4.14.2",
"lodash-es": "~4.17.21",
"luxon": "~2.3.1",
"md5": "~2.3.0",
"moment": "~2.29.1",
"moment-timezone": "~0.5.34",
"ngx-clipboard": "~15.0.1",
"ngx-stripe": "~13.0.0",
"node-interval-tree": "~1.3.3",
"normalize.css": "~8.0.1",
"pdfmake": "~0.2.4",
"perfect-scrollbar": "~1.5.5",
"resize-observer-polyfill": "~1.5.1",
"rrule": "~2.6.9",
"rxjs": "~6.6.7",
"socket.io-client": "~4.4.1",
"sortablejs": "~1.14.0",
"trust1connector": "~3.0.0",
"tslib": "~2.3.1",
"ua-parser-js": "~1.0.2",
"xlsx": "~0.18.3",
"zone.js": "~0.11.5"
},
"devDependencies": {
"@angular-builders/custom-webpack": "~13.1.0",
"@angular-devkit/build-angular": "~13.2.5",
"@angular-eslint/builder": "~13.1.0",
"@angular-eslint/eslint-plugin": "~13.1.0",
"@angular-eslint/eslint-plugin-template": "~13.1.0",
"@angular-eslint/schematics": "~13.1.0",
"@angular-eslint/template-parser": "~13.1.0",
"@angular/cli": "~13.2.5",
"@angular/compiler-cli": "~13.2.5",
"@angular/language-service": "~13.2.5",
"@ngrx/store-devtools": "~13.0.2",
"@ngtools/webpack": "~13.2.5",
"@sentry/cli": "~1.73.2",
"@stripe/stripe-js": "~1.24.0",
"@testing-library/angular": "~11.0.3",
"@testing-library/user-event": "~13.5.0",
"@types/core-js": "~2.5.5",
"@types/create-hmac": "~1.1.0",
"@types/croppie": "~2.6.1",
"@types/dwt": "~16.1.2",
"@types/file-saver": "~2.0.5",
"@types/googlemaps": "~3.43.3",
"@types/jasmine": "~3.10.3",
"@types/jasminewd2": "~2.0.10",
"@types/karma": "~6.3.3",
"@types/lodash-es": "~4.17.6",
"@types/md5": "~2.3.2",
"@types/mocha": "~9.1.0",
"@types/modernizr": "~3.5.3",
"@types/node": "~17.0.21",
"@types/pdfmake": "~0.1.20",
"@types/sortablejs": "~1.10.7",
"@types/svg-sprite-loader": "~3.9.5",
"@types/webpack-env": "~1.16.3",
"@types/youtube": "~0.0.46",
"@typescript-eslint/eslint-plugin": "~5.14.0",
"@typescript-eslint/parser": "~5.14.0",
"@types/ua-parser-js": "~0.7.36",
"chalk": "~4.1.2",
"codelyzer": "~6.0.2",
"cross-env": "~7.0.3",
"eslint": "~8.10.0",
"eslint-config-prettier": "~8.5.0",
"eslint-plugin-ngrx": "~2.0.4",
"eslint-plugin-prettier": "~4.0.0",
"eslint-plugin-rxjs": "~5.0.2",
"eslint-plugin-rxjs-angular": "~2.0.0",
"husky": "~7.0.4",
"jasmine": "~4.0.2",
"jasmine-core": "~4.0.1",
"jasmine-reporters": "~2.5.0",
"jasmine-spec-reporter": "~7.0.0",
"junit": "~1.4.9",
"karma": "~6.3.17",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~4.0.1",
"karma-jasmine-html-reporter": "~1.7.0",
"karma-junit-reporter": "~2.0.1",
"karma-mocha-reporter": "~2.2.5",
"karma-parallel": "~0.3.1",
"karma-selenium-webdriver-launcher": "~0.0.4",
"lint-staged": "~12.3.5",
"moment-locales-webpack-plugin": "~1.2.0",
"moment-timezone-data-webpack-plugin": "~1.5.0",
"ngx-i18nsupport": "~0.17.1",
"prettier": "~2.5.1",
"protractor": "~7.0.0",
"protractor-beautiful-reporter": "~1.3.6",
"protractor-fail-fast": "~3.1.0",
"sass": "~1.49.9",
"source-map-support": "~0.5.21",
"stylelint": "~14.5.3",
"stylelint-config-standard-scss": "~3.0.0",
"stylelint-config-prettier": "~9.0.3",
"stylelint-config-standard": "~25.0.0",
"svg-sprite-loader": "~6.0.11",
"svg-transform-loader": "~2.0.13",
"svgo": "~2.8.0",
"svgo-loader": "~3.0.0",
"typescript": "~4.5.5",
"ts-node": "10.2.1",
"url-loader": "~4.1.1",
"xliffsplit": "~1.1.4",
"webpack": "~5.70.0",
"webpack-dev-server": "~4.7.4"
}
eslint reports json for specific file:
[
{
"filePath": "/home/stano/projects/docker/cross-app/src/app/fixed-panel/reducers/index.ts",
"messages": [
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 21,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 21,
"endColumn": 651,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectAppointmentsState" },
"fix": { "range": [633, 650], "text": "selectAppointmentsState" },
"desc": "Prefix the selector with \"select\": `selectAppointmentsState`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 25,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 25,
"endColumn": 778,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectAppointmentsLoading" },
"fix": { "range": [755, 777], "text": "selectAppointmentsLoading" },
"desc": "Prefix the selector with \"select\": `selectAppointmentsLoading`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 30,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 30,
"endColumn": 892,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectVisibleAppointments" },
"fix": { "range": [869, 891], "text": "selectVisibleAppointments" },
"desc": "Prefix the selector with \"select\": `selectVisibleAppointments`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 35,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 35,
"endColumn": 999,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectErrorMessage" },
"fix": { "range": [983, 998], "text": "selectErrorMessage" },
"desc": "Prefix the selector with \"select\": `selectErrorMessage`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 37,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 37,
"endColumn": 1091,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectAppointmentsIds" },
"fix": { "range": [1072, 1090], "text": "selectAppointmentsIds" },
"desc": "Prefix the selector with \"select\": `selectAppointmentsIds`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 39,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 39,
"endColumn": 1185,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectFirstVisibleId" },
"fix": { "range": [1167, 1184], "text": "selectFirstVisibleId" },
"desc": "Prefix the selector with \"select\": `selectFirstVisibleId`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 41,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 41,
"endColumn": 1273,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectNowOffset" },
"fix": { "range": [1260, 1272], "text": "selectNowOffset" },
"desc": "Prefix the selector with \"select\": `selectNowOffset`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 43,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 43,
"endColumn": 1364,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectVisibleItemsCount" },
"fix": { "range": [1343, 1363], "text": "selectVisibleItemsCount" },
"desc": "Prefix the selector with \"select\": `selectVisibleItemsCount`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 45,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 45,
"endColumn": 1456,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectTodayShown" },
"fix": { "range": [1442, 1455], "text": "selectTodayShown" },
"desc": "Prefix the selector with \"select\": `selectTodayShown`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 47,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 47,
"endColumn": 1549,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectNoDefaultPastEvents" },
"fix": { "range": [1526, 1548], "text": "selectNoDefaultPastEvents" },
"desc": "Prefix the selector with \"select\": `selectNoDefaultPastEvents`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 52,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 52,
"endColumn": 1667,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectNoDefaultUpcomingEvents" },
"fix": { "range": [1640, 1666], "text": "selectNoDefaultUpcomingEvents" },
"desc": "Prefix the selector with \"select\": `selectNoDefaultUpcomingEvents`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 57,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 57,
"endColumn": 1792,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectPreviousPaginationDisabled" },
"fix": { "range": [1762, 1791], "text": "selectPreviousPaginationDisabled" },
"desc": "Prefix the selector with \"select\": `selectPreviousPaginationDisabled`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 62,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 62,
"endColumn": 1916,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectNextPaginationDisabled" },
"fix": { "range": [1890, 1915], "text": "selectNextPaginationDisabled" },
"desc": "Prefix the selector with \"select\": `selectNextPaginationDisabled`."
}
]
},
{
"ruleId": "ngrx/prefix-selectors-with-select",
"severity": 1,
"message": "The selector should start with \"select\".",
"line": 67,
"column": 14,
"nodeType": null,
"messageId": "prefixSelectorsWithSelect",
"endLine": 67,
"endColumn": 2023,
"suggestions": [
{
"messageId": "prefixSelectorsWithSelectSuggest",
"data": { "name": "selectPatientId" },
"fix": { "range": [2010, 2022], "text": "selectPatientId" },
"desc": "Prefix the selector with \"select\": `selectPatientId`."
}
]
}
],
"suppressedMessages": [],
"errorCount": 0,
"fatalErrorCount": 0,
"warningCount": 14,
"fixableErrorCount": 0,
"fixableWarningCount": 0,
"source": "import { createFeatureSelector, createSelector } from '@ngrx/store';\nimport {\n AppointmentListState,\n getErrorMessageState,\n getAppointmentsLoadingState,\n getVisibleAppointmentsState,\n geTodayShownState,\n getNoDefaultPastEventsState,\n getNoDefaultUpcomingEventsState,\n getAppointmentsIdsState,\n getFirstVisibleIdState,\n getNowOffsetState,\n getVisibleItemsCountState,\n getPreviousPaginationDisabledState,\n getNextPaginationDisabledState,\n getPatientIdState,\n} from 'app/fixed-panel/reducers/appointments.reducer';\n\nexport const appointmentsFeatureName = Symbol('appointments');\n\nexport const appointmentsState = createFeatureSelector<AppointmentListState>(\n appointmentsFeatureName.toString(),\n);\n\nexport const getAppointmentsLoading = createSelector(\n appointmentsState,\n getAppointmentsLoadingState,\n);\n\nexport const getVisibleAppointments = createSelector(\n appointmentsState,\n getVisibleAppointmentsState,\n);\n\nexport const getErrorMessage = createSelector(appointmentsState, getErrorMessageState);\n\nexport const getAppointmentsIds = createSelector(appointmentsState, getAppointmentsIdsState);\n\nexport const getFirstVisibleId = createSelector(appointmentsState, getFirstVisibleIdState);\n\nexport const getNowOffset = createSelector(appointmentsState, getNowOffsetState);\n\nexport const getVisibleItemsCount = createSelector(appointmentsState, getVisibleItemsCountState);\n\nexport const getTodayShown = createSelector(appointmentsState, geTodayShownState);\n\nexport const getNoDefaultPastEvents = createSelector(\n appointmentsState,\n getNoDefaultPastEventsState,\n);\n\nexport const getNoDefaultUpcomingEvents = createSelector(\n appointmentsState,\n getNoDefaultUpcomingEventsState,\n);\n\nexport const getPreviousPaginationDisabled = createSelector(\n appointmentsState,\n getPreviousPaginationDisabledState,\n);\n\nexport const getNextPaginationDisabled = createSelector(\n appointmentsState,\n getNextPaginationDisabledState,\n);\n\nexport const getPatientId = createSelector(appointmentsState, getPatientIdState);\n",
"usedDeprecatedRules": []
}
]
- steps to reproduce
- potential workaround
we also try to remove type ofcreateFeatureSelectorbut always broke on something about parameters.
When we sdirectly set appointmentsState: any = {} core is broke somehwere down in selectors.
Are we doing something wrong?