Examining reports on SonarCloud generated from Jenkins job kicked off by gerrit.
Sonarcloud is now reporting “Complete assertion” for assertThatThrownBy(). While it’s true that plain assertThat() and possibly assertThatCode() make no implicit assertions, that is not true for assertThatThrownBy(); the latter will fail if the invoked lambda expression does not throw an exception. Lots of test code makes use of this fact to verify that the code throws an exception.
Work-around: add “.instanceOf(Exception.class)” to the end of each assertThatThrownBy() invocation.