Catch possibly uninitialized variables in PHP

SonarQube Server / Community Build
1

Versions:

  • SonarQube 8.9.6
  • Scanner 4.2.0

A bug got through scanning that I thought would be caught. It seems as though this rule: PHP static code analysis: Variables should be initialized before use only checks if a variable is definitely undefined before it’s used. Is there a rule that cheks if a variable could be undefined before it’s used? Something like the Psalm “Possibly Undefined Variable” ?

2

Hi @joaquimds,

Welcome to the community. Can you provide some code examples for a better understanding?

Best,
Nils

5

Hi Nils,

Thank you for your reply. Here is some sample code:

<?php

// Will fail Qube
function bad() {
    $cond = true;
    if ($cond) {
        $text .= "test";
    }
    echo $text . "\n";
}
bad();

// Will not fail Qube
function alsoBad() {
    $cond = false;
    if ($cond) {
        $text = "";
    }
    $text .= "test";
    echo $text . "\n";
}
alsoBad();
6

Hi @joaquimds,

thank you for the reproducer and sorry for the late response. Currently, this is due to our missing support for path sensitivity. I’ve created a ticket which will be addressed when we enable path sensitivity for PHP.

Thanks again for your contribution.

Best,

7

Thank you!