Bug found with sonar.maven.scanAll

lbornov2paymentology · January 20, 2025, 9:19am

We are using sonarcloud.

We have a java project and are trying to enable sonar.maven.scanAll option by setting it to true.

When we set it in the properties section in pom.xml, it’s not read, and we don’t see this in the logs:

the scanner will not collect additional sources because sonar.maven.scanAll has been overridden

However, when we override the property via -D, i.e. -Dsonar.maven.scanAll=true, it’s being read, and we see this in the logs:

the scanner will not collect additional sources because sonar.maven.scanAll has been overridden

We are using the latest version of the maven plugin (i.e. we’re not specifying a version).
i.e. mvn org.sonarsource.scanner.maven:sonar-maven-plugin:sonar

Most likely, the error happens here:

github.com/SonarSource/sonar-scanner-maven

src/main/java/org/sonarsource/scanner/maven/bootstrap/ScannerBootstrapper.java

e2ddfc354


      
              }
            }
          
            return props;
          }
          
          private static boolean shouldCollectAllSources(Properties userProperties) {
            return Boolean.TRUE.equals(Boolean.parseBoolean(userProperties.getProperty(MavenScannerProperties.PROJECT_SCAN_ALL_SOURCES)));
          }
          
          private static String notCollectingAdditionalSourcesBecauseOf(String overriddenProperty) {
            return "Parameter " + MavenScannerProperties.PROJECT_SCAN_ALL_SOURCES + " is enabled but " +
              "the scanner will not collect additional sources because " + overriddenProperty + " has been overridden.";
          }
          
          private static Set<Path> excludedReportFiles(Map<String, String> props) {
            return props.keySet().stream()
              .filter(key -> REPORT_PROPERTY_PATTERN.matcher(key).matches())
              .map(props::get)
              .map(MavenUtils::splitAsCsv)
              .flatMap(List::stream)

Can you open a corresponding JIRA ticket to fix this?

I’m not sure if the error happens in gradle as well or not, I will check that.

lbornov2paymentology · January 21, 2025, 4:37pm

Any news on this? This is an issue in the maven plugin that sonar open sourced, but there’s no way to open issues on that project

Colin · January 22, 2025, 9:21am

Hey @lbornov2paymentology

You’re just going to need to be a bit more patient. We appreciate the report (and you’ve made it in the right place), but sometimes it takes more than a day for a thread to get the attention of the right team.

Dorian_Burihabwa · January 22, 2025, 6:28pm

Thank you for your report @lbornov2paymentology.

I could reproduce the issue and I created a ticket to track it.

Cheers,

Dorian