After Optional.orElseThrow()，"userInfo" is not nullable

Clean Code Report False-positive / False-negative...
, ,
1

Please provide

  • Operating system:
  • SonarLint plugin version:8.4.0.73538
  • Programming language you’re coding in: Java 8
  • Is connected mode used:
    • Connected to SonarCloud or SonarQube (and which version):

And a thorough description of the problem / question:

cusFeedback.setPhoneNumber(Optional.ofNullable(userInfo).orElseThrow(() -> new FsnException(Result.USER_NOT_EXISTS)).getPhone());
cusFeedback.setCommitName(userInfo.getName());

**

rule id :java:S2259

**

image
image1568×226 37.8 KB

I believe that the first line has already checked whether userInfo is null , and if it is null , an exception will be thrown. Therefore, the subsequent userInfo.getName() should not throw an exception.

2

Hey there.

I’ve moved your post to the section on reporting a false-positive.

Please review this post and add additional information, particularly a text-based reproducer, not a screenshot.

4

Okay, I have added the text code snippet。