Hello all, I was wondering if this rule could be visited. typescript:S6647 Unnecessary constructors should be removed. We’re using Enterprise Edition Version 10.2.1 (build 78527). The rule itself, seems to be have introduced on the 5th of September. “If the class declaration does not include a co…

We regularly extend TypeScript abstract classes with no dedicated constructor with no issues. Note that abstract classes are not a JavaScript concept but just a TypeScript one: they have no special runtime behaviour and the abstract keyword is removed.

Can you give me an example of where you would use a class extended from an abstract class without a constructor? You cant initialize an abstract class, only classes extended from it. The whole concept is to have a base template and extend from there and expand the params. Abstract classes are not…

I meant this works, following your example: abstract class Person { abstract name: string; display(): string{ return this.name; } } // This works class User extends Person { name: string; } // This too let u = new User(); Of course the name field must be initialized else…

That’s my point, sonar is smelling them as useless constructors, but they are required as the params are different…

Then I misunderstood your report, my apologies for this detour and let the discussion continue.

Hi @jamie.b , thanks for reporting this. Can you please provide a reproducer? With the code sample you provided here, I cannot see any issue raised: [image] jamie: abstract class Person { abstract name: string; display(): string{ return this.name; } } class Employee extend…

Sonar smell typescript:S6647 Unnecessary constructors should be removed

Rules and Languages Report False-positive / False-negative...

victor.diez (Victor Diez) November 2, 2023, 12:47pm 11

Hello, we have been able to reproduce the issue after another user reported the same behavior here.

Proceed to that post for future updates.

Cheers,
Victor

Topic		Replies	Views
S6647 false positive when parent constructor is protected Report False-positive / False-negative... typescript	4	543	November 2, 2023
S3854 does not understand class expressions Report False-positive / False-negative... javascript , typescript	2	197	April 19, 2024
No public constructors for abstract classes New rules / language support java	1	733	September 29, 2020
False positive S1172 for constructor parameter Report False-positive / False-negative... typescript , sonarqube-ide , sonarqube-cloud	14	2508	August 2, 2022
Java abstract classes and constructors Report False-positive / False-negative... java	1	1031	February 24, 2022

Sonar smell typescript:S6647 Unnecessary constructors should be removed

Related topics