Hi .NET folks We’ve all felt the pain of deadlocks so now SonarSource has a new rule for C# and VB.NET that can detect when a resource has been locked and might not get released. It’s the first rule to benefit from our new Symbolic Analysis engine and we’re pretty excited about it. It’s been enable…

That is a nice addition. It might be worth to add another rule in this erea: Non-compliant private object lock = new object(); // Noncompliant {{lock objects should be read-only.}} Compliant private readonly object lock = new object();

Thanks Corniel :slight_smile: Yes, that’s a great suggestion for a rule, we’ll see what we can do Tom

It might also be possible to check if the lock should be static or not, but that is way less forward, so I’m not sure if you can prevent (too many) false positives.

Thank you @Corniel for this suggestion. I’ve captured the idea here: New Rule: Lock objects should be read-only opened 11:18AM - 04 Apr 22 UTC (UTC) [pavel-mikula-sonarsource] pavel-mikula-sonars…

That rule will only trigger if the lock object is not re-assigned, which is good obviously. It will not detect if a lock object is abused for something else; the reason to require it to be read-only in the first place. If that is worth the hassle is not up to me. Therefor just as a suggestion.

Another related rule might be that a static lock object should never be decorated with [ThreadStatic].

It appears to be confused by the use of Monitors directly: [image]

Hey @DotMPP Mind sharing more details (and a text-based code sample) over here ? [image] How to Report a False-positive / False-negative Report False-positive / False-negative... Hey SonarSource Community! False-positives happen , as do false-negatives, and we…

New Rule for C# and VB.NET - Locks should be released!

Sonar Updates

Colin (Colin) January 7, 2025, 5:18pm 9

Hey @DotMPP

Mind sharing more details (and a text-based code sample) over here?

Topic		Replies	Views
New Rule: Prefer usage of System.Threading.Lock over object for lock statements Rules and Languages dotnet	3	103	April 7, 2026
Improved Null Issue detection in C# and VB.NET Sonar Updates sonarqube , dotnet , sonarqube-cloud	0	403	April 21, 2023
13 New code quality rules for .Net developers Sonar Updates csharp , vbnet	0	1226	October 30, 2019
csharpsquid:S2743 Static fields should not be used in generic types on lock object Report False-positive / False-negative... csharp	1	1341	December 15, 2020
New rules for .NET developers Sonar Updates csharp , vbnet , dotnet	0	1754	March 10, 2023

New Rule for C# and VB.NET - Locks should be released!

Related topics