Qube: Community 9.9 The Java rule S5993 has a default severity of Major. I don’t think, this is correct. It should at most be Minor. While there is no point in making the constructors public there is also no risk. It is more or less nice to have to make them protected. Yes, it is a good thing to …

Qube: Community 9.9 The Java rule S2864 has a default severity of Major. The rule is about coding style and maybe a bit of performance. But nothing is really wrong iterating over keys and querying the value via get(key). Severity should be lowered to Minor.

Qube: Community 9.9 The Java rule S1604 has a default severity of Major. The rule is purely about coding style and using new features. It is great, that this rule reminds me about places, where I did not yet migrate to lambdas. Though it is nothing wrong using old style closure. Default severity s…

Hi Ann, that’s fine for me. This sub categorization was a bit random anyways. But maybe it is worth for the current smells to get raised to bugs when severity is gone. I know, it sounds odd. But it may be worth a thought. Cheers Marvin

Hi Marvin, Thanks for bringing this up. I think the points you bring up have merit and the Java squad could consider them, I’ll ping them. How are you using severity in your workflow? Do you have quality gates with conditions on severity? Just to clarify, we’ve changed how severity works, it is …

Of course I meant “…worth for some of the current smells…”, not “…worth for the current smells…”.

Yes, we’ve defined a quality gate. From our point of view some of the smells can be treated like what they are named and don’t necessarily have to be dealt with, if time is crucial. But others, which are more or less those with a severity of Major and above, really pay into the code cleannes when fi…

[java:S5993] Lower severity

SonarQube Server / Community Build

ganncamp (G Ann Campbell) October 3, 2023, 12:00pm 5

Hi,

Thanks for these reports. Normally your one-thread-per-rule format is perfect, and absolutely what we want. However, I’ve combined these three threads because I have the same answer to all three of them:

We’ve deprecated severity, and the plan is that it will soon disappear from the product. So we aren’t likely to make this change.

You can read more here:

Ann

Topic		Replies	Views
Edit rule severity in SonarLint SonarQube Server / Community Build sonarqube , sonarqube-ide	1	849	January 10, 2020
SQ 10.2 turn off rule severity is a breaking change SonarQube Server / Community Build rules	53	5441	December 12, 2024
Introducing Clean Code in our products Sonar Updates sonarqube , clean-code , sonarqube-ide , sonarqube-cloud	12	3637	November 14, 2024
Wrong severity level for external issues Writing rules scala	1	895	December 10, 2021
SonarQube custom rule Writing rules java , sonarqube	2	539	October 20, 2023

[java:S5993] Lower severity

Related topics