Hello. Not sure if i’m writing to a correct category, those, who are moderating the forum, please feel free to move this topic to where it’s appropriate. I want to discuss Java rules used to check the floating point operations. My case is: when i use direct comparison (dValue == 0) ? 0 : (some / d…

[image] Ivan I. Ovchinnikov: (dValue < 0.00001) ? 0 : (some / dValue); I have no insights in the implementation of this rule, but the first thing I notice that this also returns 0.0 for negative values, is this intended?

true, both snippets are doing the same thing – trying to avoid division by zero, more or less effectively. but different comparison implementations are triggering different rules, so i guess at least one of them needs to be enhanced… to be more clear, i’ll edit the second snippet with an additional…

there is a way to avoid an issue by moving calculations to a separate method like this: public double safeDivide(double numerator, double denominator, double tolerance) { return (Math.abs(denominator) < tolerance) ? 0 : (numerator / denominator); } and invoking this method where ru…

Hi Ivan, I looked at the example that you provided, but could not reproduce S3518. Are you sure that the condition is correct? dValue < 0.00001 || dValue > -0.00001 looks like a condition that is always false, maybe you meant dValue < 0.00001 && dValue > -0.00001?

Hello, Tomasz. I think, that it actually doesn’t matter if it’s “and” or “or”, neither of them guarantee that dValue won’t be zero. Could it be a SonarQube for IDE issue to trigger a rule violation? SonarQube for IDE 10.14.0.80203 (Intellij IDEA)

Could you please share a complete method that reproduces the issue? The problem appears similar to what’s described in the following ticket, but I am not certain if it is the same: JAVASE-20 .

[image] Ivan I. Ovchinnikov: (dValue == 0) ? 0 : (some / dValue); As i mentioned in Java floating point mathematics rules - #5 by ivan-igorevich if i do it in a separate method, the rule is not triggered. [image] but when i do it in more complex method (which i cannot put here uncensored) …

Good evening, community, found some time to extract the logic that false positively triggers S3518 package org.example; public class Main { private static final double DIV_EPSILON = 1e-9; /** * Division rules sample. * * @return some nice divided double value * */ p…

Thank you for the reproducer! I created JAVASE-21 for this issue.

Java floating point mathematics rules

Rules and Languages New rules / language support

tomasz.tylenda (Tomasz Tylenda) August 26, 2025, 11:23am 11

Thank you for the additional info! Unfortunately, I will not be able to create a ticket without an example reproducing the issue.

2 Likes

Topic		Replies	Views
Enhance FloatEqualityCheck to test not only for equality but also for comparsion with doubles New rules / language support java , github-checks	7	213	August 19, 2025
False Negative: squid:S3518: Divide by zero does not check BigDecimal SonarQube Server / Community Build java , bug-no-category	1	1074	April 6, 2020
[java:S2164] FP Report False-positive / False-negative... java , sonarqube , bump	3	331	August 12, 2023
S3518 reporting division by zero with double as throwing arithmetic exception Report False-positive / False-negative... java	2	1282	January 28, 2019
MathUtils.GreaterThanZero giving High severity issue on SonarCloud Issue SonarQube Cloud coverage	7	97	July 30, 2024

Java floating point mathematics rules

Related topics