FN in S2221: Catching a Generic Exception not reported as issue

SonarQube
3

Hello, welcome to the community!

Indeed, since dataBuffer.put(op); is not throwing explicitly Exception, this is exactly the kind of issue that the rule should detect.
As a test, you could try to change your code to:

@Override
public void putData(AbstractCortexOperation op) {
    try {
        //dataBuffer.put(op);
        foo();
    } catch (final NullPointerException e) {
        LOGGER.log(Level.WARNING, "Some error text", e);
    } catch (final Exception e) {
        LOGGER.log(Level.WARNING, "Some other error text: ", e);
    }
}

void foo() throws NullPointerException,InterruptedException {}

You should see an issue there. (at least, I have it on my side).

  • If you don’t see an issue.

This means that the rule is not executed. I advise you to double-check that everything is correctly configured (see the documentation). Specifically that the profile containing the rule is the default one for Java.

  • If you see an issue.

My guess is that the analyzer cannot resolve the method call dataBuffer.put(op);. In such cases, we are not reporting an issue to avoid false positives. It’s typically due to a project’s properties misconfiguration (probably sonar.java.libraries missing). Checks the logs if you see something strange. I invite you to have a look there, it’s not the same root cause, but I believe the resolution is the same.

I hope this will leads your researches.
Best,
Quentin

1 Like