Value stored to 'adc_reading ' is never read

franz_at_zasso · November 27, 2021, 5:40pm

This code:

espressif/esp-idf/blob/master/examples/peripherals/adc/single_read/adc/main/adc1_example_main.c

/* ADC1 Example

   This example code is in the Public Domain (or CC0 licensed, at your option.)

   Unless required by applicable law or agreed to in writing, this
   software is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
   CONDITIONS OF ANY KIND, either express or implied.
*/
#include <stdio.h>
#include <stdlib.h>
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#include "driver/gpio.h"
#include "driver/adc.h"
#include "esp_adc_cal.h"

#define DEFAULT_VREF    1100        //Use adc2_vref_to_gpio() to obtain a better estimate
#define NO_OF_SAMPLES   64          //Multisampling

static esp_adc_cal_characteristics_t *adc_chars;

This file has been truncated. show original

in the line:

adc_reading /= NO_OF_SAMPLES;

i get a Value stored to 'adc_reading ’ is never read

but in fact the Variable is read in Line 104.

how to solve ?

necto · December 7, 2021, 8:13am

Hi @franz_at_zasso

Thanks for reporting this potential false positive.
I didn’t succeed in reproducing the issue on my side so do you think you could create a small reproducer for it?
To generate a reproducer file:

Add the reproducer option to the scanner configuration:
sonar.cfamily.reproducer= "Full path to the adc1_example_main.c file"
Re-running the scanner should generate a file named sonar-cfamily.reproducer in the project folder.
Please share this file (I can send you a PM if you want to share it privately)

Thank you

necto · June 2, 2022, 9:38am

Hi @franz_at_zasso
Please let me know if you still experience the issue. In the absence of a reply, I’ll close this topic.

system · July 4, 2022, 11:20am

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.

necto · July 4, 2022, 11:21am

@franz_at_zasso , I’m closing the topic. Feel free to open another one with additional information I requested if you still encountering the issue.