[Java:S2390] Accept inline child classes

[mfroehlich (Marvin Fröhlich)]

This code should not violate rule S2390:

public class Parent
{
    private static class Child extends Parent
    {
    }
    
    public static final Parent INSTANCE1 = new Child();
}

I don’t think, this really applies to what to rule aims for. And I don’t see a reason, why this should not be accepted.

[Michael (Michael Gumowski)]

Hello,

Can you please split your message into several threads?
It seems to me that the following is not at all related to your report about the FP on java:S2390.

@mfroehlich

[Lint] Specify default Qube binding in Workspace

There should be a way to specify a default/fallback rule set, that actually comes from SonarQube for projects without a specific SonarQube binding.

Currently all not bound projects produce A LOT of unwanted problems, because the Lint settings are at default (and they cannot be imported and hence set to something useful).

One time check with other quality profiles

Qube and Lint should provide an option to perform a one time check with different quality profiles (usually more strict ones) than bound and activated.

Many rules are not really relevant for the every day code work. But it’s interesting to know about some smells in your code from time to time.
r formatting

Thanks,
Michael

[mfroehlich (Marvin Fröhlich)]

Thanks, Michael. I have fixed that. And sorry for that.

[Quentin (Quentin Jaquier)]

Hello @mfroehlich,

Thanks for raising this issue, this is an interesting and quite tricky problem.

I don’t see a reason, why this should not be accepted.

My first feeling is the same. And in fact, even if one can come up with something not behaving as expected when the Child class is nested into the Parent, differentiating the case where it is or not a problem would be tricky. I therefore created a ticket (SONARJAVA-3580) to not report an issue in such situation.

If someone is interested in this topic, feel free to dig further, if you can come up with a concrete example, I would be happy to follow up on this.

[mfroehlich (Marvin Fröhlich)]

@Quentin

I therefore created a ticket

Nice! Thanks.