Environment:
SonarLint 5.3.0.36775 SonarSource
Clion 2021.1.3
Ubuntu 20.04.3 LTS
False positive on code, where move constructor assigns values to fields of the source object. In this case initialization list can’t be used to modify the source object. The rule should only be triggered if fields of the current object are assigned in the constructor, not when fields of other instances of the same type.
class Resource
{
public:
Resource() = default;
Resource(Resource&& source) noexcept : resourceId(source.resourceId)
{
source.isResourceOwned = false; // false positive of cpp:S3230
}
~Resource()
{
if (isResourceOwned)
releaseResource(resourceId);
}
private:
int resourceId = acquireResource();
bool isResourceOwned = true;
static int acquireResource()
{
return 1; // pretend this method allocates some resource and returns some id for it
}
static void releaseResource(int)
{
// pretend this method releases some resource
}
};