csharpsquid:S4462: Not throwing Blocker

Clean Code Report False-positive / False-negative...
,
1
  • which versions are you using (SonarQube)
    SonarQube: 9.7.1.62043
  • what are you trying to achieve
    Get rule csharpsquid:S4462 to block my quality gate.
  • what have you tried so far to achieve this
    Insert code that is exactly what the rule complains about.
public static ICollection AddContext(this ICollection services)
{
   services.AddScoped<IContextSetter>((services) =>
    {
       var respository = services.GetRequiredService<IRepository>();
       return new Context
         {
            Value = Task.Run(() => respository.GetCurrent()).GetAwaiter().GetResult()
         };
   });
   services.AddScoped<IContext>((services) => services.GetRequiredService<IContextSetter>());
   services.AddTransient<ContextMiddleware>();
   return services;
}
2

Hi,

You can’t set Quality Gate conditions on specific rules. What you can do is set conditions on categories of rules. For instance, I see that by default S4462 is a Blocker. So you could set a condition on the number of Blocker issues.

 
HTH,
Ann

3

Thanks for your answer. To make it clear, the condition is not blocking the quality gate because Sonarqube does not see this rule on that snipped of code, there is no issue thrown in any of our applications. 0 issues on rule csharpsquid:S4462 in arround 3/4 million lines of code, thats a llitlebit strange.

4

Hi,

Okay! So this is actually a report of a false negative. I missed that in the discussion of failing the Quality Gate.

I’ve moved this to the FP/FN category & I’ll ping the language team.

 
Ann

6

Hello @sweise,

Rule S4462 is not enabled by default (see defaultQualityProfiles). You need to extend your quality profile to activate the rule. You can find more information about how to do it in the documentation.

Best regards, Martin

8

Perfect thank you that worked for me.

10

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.