Some days back I created the following PR to support the AWS advanced JDBC driver for Postgres to allow using IAM roles to authenticate against RDS Postgres.
I was wondering if it would be possible to have a review of the PR or some guidance on how to use the AWS driver with SonarQube.
As mentioned in the description of the PR, at least two posts on this forum are requesting such features, the modification in my PR could allow using IAM roles to use the official AWS approach for the feature for the Postgres.
Thanks a lot for your contribution, I assigned to me your PR for review.
I know that the code change in your PR is trivial, but we need to assess what are the global implications of allowing dashes in the JDBC URL plus add some tests before be able to merge the change to our code base.
I will update the PR once we are done with its review, sorry for the delay in providing you a proper answer in a shorter timeframe.
As mentioned in the pull reques, we created a Sonar ticket with all the details related to this change, this is being discussed with the PMs. And it will be prioritized accordingly to our roadmap.
I closed the PR in the meantime, but you will be able to follow the evolution on the Jira.
Allowing hyphens turned out to be more complex than initially anticipated. In fact simply modifying the regular expression isn’t sufficient. To fully implement this, we would need to officially support other drivers (like your example, aws-wrapper).
Therefore, the decision has been made not to proceed with this change at this time. However, if we receive more requests for this feature in the future, we would certainly be open to reconsidering.
Thank you for your proposal and your understanding.